search

nilsherzig / LLocalSearch

LLocalSearch is a completely locally running search aggregator using LLM Agents. The user can ask a question and the system will use a chain of LLMs to find the answer. The user can see the progress of the agents and the final answer. No OpenAI or Google API keys are needed.
Apache License 2.0
5.59k stars 354 forks source link

Update README architecture link #88

Closed suparious closed 4 months ago

suparious commented 5 months ago

As the link changed from a issue to a discussion I also wanted to take the opportunity to update the language, as this is not infrastructure, it is architecture.

nilsherzig commented 5 months ago

Oh thanks, you're right about that. May I ask you something? Are there any benefit of opening a pull request besides fixing the link? I get a lot of single line change pull requests

suparious commented 5 months ago

@nilsherzig - For me the benefit is with the new users coming to the project and possibly getting put off by finding documentation links that lead to 404 errors, and language that doesn't make logical sense.

I guess the language change was pedantic, but important, as infrastructure and architecture are different specializations / disciplines, and some people are not familiar with both.

Also, seeing your response and question to my simple PR, gives me confidence that this project would be something that I would want to spend time on and make a real contribution.