nim-works / nimskull

An in development statically typed systems programming language; with sustainability at its core. We, the community of users, maintain it.
https://nim-works.github.io/nimskull/index.html
Other
279 stars 39 forks source link

fix fields with names containing backticks being inaccessible #1389

Closed zerbina closed 4 months ago

zerbina commented 4 months ago

Summary

Fix a regression where field names with backticks in them couldn't be accessed with a field access.

Fixes https://github.com/nim-works/nimskull/issues/1379.

Details

Looking for the full "`gensym" suffix wouldn't work, because it would also trigger the stripping for user-created names containing the suffix.

saem commented 4 months ago

/merge

github-actions[bot] commented 4 months ago

Merge requested by: @saem

Contents after the first section break of the PR description has been removed and preserved below:


## Notes for Reviewers * an interim solution until symbol binding/lookup for templates is overhauled, at which point the node flag becomes obsolete again * a regression introduced by #1298