nim-works / nimskull

An in development statically typed systems programming language; with sustainability at its core. We, the community of users, maintain it.
https://nim-works.github.io/nimskull/index.html
Other
275 stars 39 forks source link

fix: incorrect code generation for parameter borrowing #1460

Closed zerbina closed 3 weeks ago

zerbina commented 3 weeks ago

Summary

Fix parameters below the pass-by-reference size threshold not being passed by reference when the procedure returns a non-direct view, resulting in access violations at run-time when trying to access the returned view.

Details

Fixes https://github.com/nim-works/nimskull/issues/1457.

saem commented 3 weeks ago

/merge

github-actions[bot] commented 3 weeks ago

Merge requested by: @saem

Contents after the first section break of the PR description has been removed and preserved below: