search

nimblehq / rails-templates

Our optimized Rails templates used in our projects
https://nimblehq.co
MIT License
103 stars 25 forks source link

Using docker addon param actually causes that the dockerized app files are not installed #210

Open caherrerapa opened 4 years ago

caherrerapa commented 4 years ago
  1. Create a project from the template using the add on parameter as docker
  2. The project will not have any related docker files

It seems it works in the opposite way as setting the addon causes it's not used. A bit counterintuitive.

andyduong1920 commented 4 years ago

Hi @caherrerapa first of all, currently the template doesn't support choosing the addon on the new project process, like rails new test_template -m rails-templates/template.rb ADDON=docker, so on the new project process, the user has to go through all add-ons. Refer https://github.com/nimblehq/rails-templates#use-the-template.

andyduong1920 commented 4 years ago

I also try to create a new project with the ADDON option, and it seems the template work as expected.

https://drive.google.com/file/d/1fzEgsCT-FrFM32wcUtsc1aptIU0OUkGQ/view?usp=sharing

But we don't recommend to do that because when we would like to generate a new project from the template, the user has to follow the template instead of pre-selecting Addon.

andyduong1920 commented 4 years ago

While following the template, the user will have the option to choose to apply the addon or not, for example, the PhraseApp addon https://github.com/nimblehq/rails-templates/pull/231