nimroddolev / chime_tts

A custom Home Assistant integration to play combined audio files before and/or after text-to-speech (TTS) messages
https://nimroddolev.github.io/chime_tts/
MIT License
196 stars 14 forks source link

Duplicate keys for cache options in clear_cache services.yaml #177

Closed gdgib closed 1 month ago

gdgib commented 3 months ago

System Health details

N/A

Checklist

Describe the issue

https://github.com/nimroddolev/chime_tts/blob/main/custom_components/chime_tts/services.yaml#L13 and https://github.com/nimroddolev/chime_tts/blob/main/custom_components/chime_tts/services.yaml#L39 have the same key, and are almost identical.

This was introduced in https://github.com/nimroddolev/chime_tts/commit/77ae85ad43b02e97320c62d0968de0d3e1c07907#diff-fe4ec1ac4b861db56792ba5b0e27b95abe4a6b7d4ec5c5a796854499012ef5a8

I'm not sure how you would prefer to resolve it, since they're almost identical.

Reproduction steps

  1. Run 1.1.4-beta4
  2. Examine the HA core logs

Debug logs

N/A

Diagnostics dump

No response

gdgib commented 3 months ago

Don't get me wrong if you REALLY want debug logs for this I will, but since I provided links to the exact lines of yaml that aren't correct, I figured you probably didn't need much more. Apologies if I'm wrong, and thanks for all the hard work!

nimroddolev commented 2 months ago

Hi @gdgib, thanks for opening this issue. I have already fixed this bug in one of the beta versions. I will close this issue once the fix is available in a stable release.

nimroddolev commented 1 month ago

Hi @gdgib. I fixed this issue in v1.1.4. Can you please verify that it's working for you?

gdgib commented 1 month ago

Oh sorry! Yeah, this looks good to me.

gdgib commented 1 month ago

Thank you so much!