search

nipreps / sdcflows

Susceptibility Distortion Correction (SDC) workflows for EPI MR schemes
https://www.nipreps.org/sdcflows
Apache License 2.0
32 stars 26 forks source link

ENH: Standalone CLI now estimates fieldmaps #408

Closed oesteban closed 11 months ago

oesteban commented 1 year ago

The previous behavior (just "finding" estimators) is maintained with the argument --dry-run.

codecov[bot] commented 1 year ago

Codecov Report

Attention: 219 lines in your changes are missing coverage. Please review.

Comparison is base (53482c1) 80.59% compared to head (a77775f) 76.66%.

:exclamation: Current head a77775f differs from pull request most recent head a682abe. Consider uploading reports for the commit a682abe to get more accurate results

Files Patch % Lines
sdcflows/config.py 73.83% 72 Missing and 12 partials :warning:
sdcflows/cli/main.py 40.00% 47 Missing and 4 partials :warning:
sdcflows/cli/parser.py 64.00% 30 Missing and 6 partials :warning:
sdcflows/workflows/fit/base.py 8.33% 22 Missing :warning:
sdcflows/cli/workflow.py 13.33% 13 Missing :warning:
sdcflows/utils/telemetry.py 37.50% 10 Missing :warning:
sdcflows/fieldmaps.py 71.42% 0 Missing and 2 partials :warning:
sdcflows/_warnings.py 92.30% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #408 +/- ## ========================================== - Coverage 80.59% 76.66% -3.93% ========================================== Files 26 32 +6 Lines 2293 2824 +531 Branches 291 373 +82 ========================================== + Hits 1848 2165 +317 - Misses 401 593 +192 - Partials 44 66 +22 ``` | [Flag](https://app.codecov.io/gh/nipreps/sdcflows/pull/408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipreps) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/nipreps/sdcflows/pull/408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipreps) | `∅ <ø> (∅)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipreps#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

oesteban commented 1 year ago

Well, at df93c7b, this is surprisingly executing the estimation of GRE fieldmaps. EPI fieldmaps failed in the robust average, so I'll need to check what went wrong.