Open tsalo opened 6 months ago
I cannot figure out how to get the FieldmapWrangler to find MEDIC-style setups (i.e., complex-valued, multi-echo BOLD scans). 😕
@tsalo Around L508 in your current wrangler.py
, I think you want to do something like:
medic_entities = {**base_entities, **{'part': 'mag'}}
has_magnitude = tuple()
with suppress(ValueError):
has_magnitude = layout.get(
suffix='bold',
**medic_entities,
)
for mag_img in has_magnitude:
phase_img = layout.get(**{**mag_img.get_entities(), **{'part': 'phase'}})
if not phase_img:
continue
phase_img = phase_img[
try:
e = fm.FieldmapEstimation(
[
fm.FieldmapFile(mag_img.path, metadata=mag_img.get_metadata()),
fm.FieldmapFile(phase_img.path, metadata=phase_img.get_metadata()),
]
)
except (ValueError, TypeError) as err:
_log_debug_estimator_fail(
logger, "potential MEDIC fieldmap", [mag_img, phase_img], layout.root, str(err)
)
else:
_log_debug_estimation(logger, e, layout.root)
estimators.append(e)
Attention: Patch coverage is 60.17699%
with 45 lines
in your changes missing coverage. Please review.
Project coverage is 78.25%. Comparing base (
656a51d
) to head (1ba3e94
).
:exclamation: There is a different number of reports uploaded between BASE (656a51d) and HEAD (1ba3e94). Click for more details.
HEAD has 18 uploads less than BASE
| Flag | BASE (656a51d) | HEAD (1ba3e94) | |------|------|------| ||24|6|
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks @effigies!
I created a MEDIC-compliant test dataset (dsD), but it seems like the tests in test_wrangler use skeletons. Should I drop the test dataset and just generate a skeleton in the test file?
Should I drop the test dataset and just generate a skeleton in the test file?
Yeah, seems like a good idea.
@effigies I finally got the tests passing. Do you know what my next steps should be?
Closes #36. An alternative to #435 that installs MEDIC as a dependency instead of implementing the whole tool as a series of interfaces and workflows.
Changes proposed: