search

nipreps / sdcflows

Susceptibility Distortion Correction (SDC) workflows for EPI MR schemes
https://www.nipreps.org/sdcflows
Apache License 2.0
32 stars 26 forks source link

ENH: Dilate fmap and bold masks during coregistration #463

Closed psadil closed 1 month ago

psadil commented 1 month ago

Closes #461

The chosen radius (5 voxels) is a bit of a guess based on what has worked in the dataset where I was noticing failures. Input on a more systematic way to select this would be welcome.

psadil commented 1 month ago

Sorry, but it's not clear to me why that test is failing. I guess it's this doctest? https://github.com/nipreps/sdcflows/blob/1350d57ee0297a3c56342e2b1bf2e5a327a2cb1b/sdcflows/utils/wrangler.py#L107-L113

effigies commented 1 month ago

Ah, it's global state and parallel tests interacting poorly. I'll figure out what's needed to isolate the state better.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.68%. Comparing base (18e5e95) to head (85e0197). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #463 +/- ## ========================================== + Coverage 83.66% 83.68% +0.01% ========================================== Files 32 32 Lines 2816 2819 +3 Branches 377 377 ========================================== + Hits 2356 2359 +3 Misses 390 390 Partials 70 70 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.