search

nipreps / sdcflows

Susceptibility Distortion Correction (SDC) workflows for EPI MR schemes
https://www.nipreps.org/sdcflows
Apache License 2.0
32 stars 26 forks source link

 [FIX] force_fmapless on top of self-correcting pepolar bold #465

Open bpinsard opened 1 month ago

bpinsard commented 1 month ago

When force_fmapless is used on top of self-correcting pepolar bold, the fmapless estimator will get it's name from B0FieldIdentifier, creating a duplicate. For now I just created a test to replicate that behavior and triggering the error that this PR will try to fix.

bpinsard commented 1 month ago

Also, it seems there was no test for force_fmapless=True.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.75%. Comparing base (656a51d) to head (a2a6877).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #465 +/- ## ======================================= Coverage 83.75% 83.75% ======================================= Files 32 32 Lines 2831 2831 Branches 381 284 -97 ======================================= Hits 2371 2371 Misses 390 390 Partials 70 70 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bpinsard commented 1 month ago

Not sure how that will behave with multi-subject cases, seee https://github.com/nipreps/sdcflows/issues/455 . Maybe that should be covered in tests.