codecov[bot]
commented
8 months ago Codecov Report
Attention: Patch coverage is 89.18919% with 4 lines in your changes are missing coverage. Please review.
Project coverage is 78.59%. Comparing base (
2355035) to head (9f13a86). Report is 5 commits behind head on master.
| Files | Patch % | Lines |
|---|---|---|
| smriprep/interfaces/templateflow.py | 92.00% | 2 Missing :warning: |
| smriprep/workflows/outputs.py | 81.81% | 2 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #418 +/- ## =========================================== + Coverage 62.91% 78.59% +15.67% =========================================== Files 24 30 +6 Lines 1912 2088 +176 Branches 242 248 +6 =========================================== + Hits 1203 1641 +438 + Misses 676 415 -261 + Partials 33 32 -1 ``` | [Flag](https://app.codecov.io/gh/nipreps/smriprep/pull/418/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipreps) | Coverage Δ | | |---|---|---| | [ds005](https://app.codecov.io/gh/nipreps/smriprep/pull/418/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipreps) | `∅ <ø> (?)` | | | [ds054](https://app.codecov.io/gh/nipreps/smriprep/pull/418/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipreps) | `46.28% <67.56%> (?)` | | | [pytest](https://app.codecov.io/gh/nipreps/smriprep/pull/418/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipreps) | `68.29% <89.18%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipreps#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This addresses https://github.com/nipreps/fmriprep/issues/3240, a few changes were necessary:
templateflow.api.get())sloppyparameter toinit_template_iterator_wf, since the T1w/brain mask's resolution (used inSpatialNormalization) depends on this parameter as well.I stripped out most of the logic in
TemplateFlowSelectto avoid duplicating the behavior, since it is essentially linked.