nipreps / smriprep

Structural MRI PREProcessing (sMRIPrep) workflows for NIPreps (NeuroImaging PREProcessing tools)
https://nipreps.github.io/smriprep
Apache License 2.0
134 stars 39 forks source link

FIX: Select function in segmentation resampling workflow #450

Closed mgxd closed 3 months ago

mgxd commented 3 months ago

The segmentation selection code was a bit convoluted, this addresses the following:

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.71%. Comparing base (f368a28) to head (4738420). Report is 6 commits behind head on master.

Files Patch % Lines
smriprep/workflows/surfaces.py 91.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #450 +/- ## ========================================== + Coverage 66.36% 66.71% +0.35% ========================================== Files 31 31 Lines 2072 2076 +4 Branches 249 246 -3 ========================================== + Hits 1375 1385 +10 + Misses 696 690 -6 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mgxd commented 3 months ago

@effigies can we sneak this into a patch release, or will it require a new minor?

effigies commented 3 months ago

I'm okay with a patch release. The workflow cache invalidation is straightforward here.