codepathreview
commented
8 years ago :+1: Excellent work, Vidhur! A few notes after checking out the code:
- Good work with the login page animations and favorite/retweet functions
- Good to see you were able to format the timestamp cleanly
- Good to see you refreshed the timeline after composing a new tweet
- Nice touch with the character count being displayed while the user composes a tweet
- Nice to see you used a
SwipeRefreshLayoutlibrary for easy timeline refreshes - Glad to see you made the compose activity into a dialog instead
- Great job embedding media image in tweet object
- Consider adding
ActiveAndroidto the Tweet and User. See the persistence guide and this other guide for more details. - Consider adding progress bars to your app whenever a network request goes out
Here's a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.
Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, ActionBar, Navigation, Models, Authentication, API Communication, Persistence, et al) and see how they all fit together. We are close now to a turning point in the course where you should be hitting a "critical mass" towards your knowledge of Android.
nirvanalab
Dear Review team,
My app NeatTweet is ready for review. Kindly review it . I look forward to hearing your feedback. /cc @codepathreview @codepath
I had experienced one challenge of rendering web content in optimized way for tweets , which didn't have any media (photo,video) . I created the url for text tweets by "https://twitter.com/i/cards/tfw/v1/ " + tweetID and it was giving back a nice card like interface. But rendering multiple webviews within each row of RecyclerView was not an optimal solution. I was trying to get a "snapshot" of the url so that I can render it in image, but didn't get the result I was hoping. Finally paused this trial since I was short of time. It will be helpful to learn if there is a neat trick to get a url snapshot (in background ) to render it for tweets with no media. Thanks!