search

nissl-lab / npoi

a .NET library that can read/write Office formats without Microsoft Office installed. No COM+, no interop.
Apache License 2.0
5.7k stars 1.43k forks source link

Use of legacy .Signed MathNet.Numerics package causing build issues #1365

Open jas88 opened 3 months ago

jas88 commented 3 months ago

NPOI Version

2.7.0

Issue Description

The developers of MathNet.Numerics have two variants, the main one and a legacy .Signed variant with a strong name, both of which identify internally as MathNet.Numerics; the developers themselves state that "This package contains strong-named assemblies for legacy use cases (not recommended)" and Microsoft say "Strong naming has no benefits on .NET Core/5+." Is there a need to keep using the legacy version rather than switching to the (much more popular) regular one?

tonyqus commented 3 months ago

Microsoft say "Strong naming has no benefits on .NET Core/5+."

Where do you get this? Can you give me a url or something?

jas88 commented 3 months ago

First sentence of the last paragraph of the first section here: https://learn.microsoft.com/en-us/dotnet/standard/library-guidance/strong-naming

I think I saw an issue from a Dutch developer asking for something to avoid triggering the warning MS say can safely be disabled as irrelevant on modern apps.

If it does concern legacy users, I think making the Framework 4.7.2 dependencies include the Signed version and the Core/6.0 one use the regular unsigned one might suit everyone.