Closed pflanner closed 8 years ago
Many thanks for this - I haven't had time to look into it, but I will soon.
On 09/08/2015 02:16, pflanner wrote:
I've had a couple of stocks show up on the widget with "N/A" as the name (ITEK is an example), but I noticed that it showed up in suggestions and the preferences page correctly. I made this update to attempt to get the stock name from suggestions if it comes back "N/A" from the quotes api.
You can view, comment on, or merge this pull request online at:
https://github.com/niteshpatel/ministocks/pull/26
Commit Summary
Update StockQuoteRepository to try to get the stock name from StockSuggestions if the name appears as "N/A"
File Changes
- M src/nitezh/ministock/StockSuggestions.java https://github.com/niteshpatel/ministocks/pull/26/files#diff-0 (2)
- M src/nitezh/ministock/domain/StockQuote.java https://github.com/niteshpatel/ministocks/pull/26/files#diff-1 (4)
M src/nitezh/ministock/domain/StockQuoteRepository.java https://github.com/niteshpatel/ministocks/pull/26/files#diff-2 (24)
Patch Links:
- https://github.com/niteshpatel/ministocks/pull/26.patch
- https://github.com/niteshpatel/ministocks/pull/26.diff
— Reply to this email directly or view it on GitHub https://github.com/niteshpatel/ministocks/pull/26.
Hi there do you still need this? ITEK is not coming up as N/A and I haven't seen any others. Let me know, otherwise I'll close this requests after a week.
I've only returned to actively developing this, hence the late reply - sorry about that.
Closing after a week of no reply.
I've had a couple of stocks show up on the widget with "N/A" as the name (ITEK is an example), but I noticed that it showed up in suggestions and the preferences page correctly. I made this update to attempt to get the stock name from suggestions if it comes back "N/A" from the quotes api.