nitin42 / glamorous-primitives

πŸ’„ style primitive React interfaces with glamorous
91 stars 9 forks source link

Deprecation: createClass & failed proptypes #5

Open alechp opened 7 years ago

alechp commented 7 years ago

Output on clean install / render:

screen shot 2017-10-03 at 3 11 16 pm

> glamorous-example@1.0.0 start .../react-sketchapp-glamorous
> npm run render

> glamorous-example@1.0.0 render .../react-sketchapp-glamorous
> skpm build --watch --run

πŸ–¨  Copied src/manifest.json in 4ms
Warning: Accessing createClass via the main React package is deprecated, and will be removed in React v16.0. Use a plain JavaScript class instead. If you're not yet ready to migrate, create-react-class v15.* is available on npm as a temporary, drop-in replacement. For more info see https://fb.me/react-create-class
Warning: Failed prop type: Invalid prop `style` of type `array` supplied to `View`, expected `object`.
    in View (created by glamorous(View))
    in glamorous(View) (created by App)
    in App
Warning: Failed prop type: Invalid prop `style` of type `array` supplied to `Image`, expected `object`.
    in Image (created by glamorous(Image))
    in glamorous(Image) (created by App)
    in view (created by View)
    in View (created by glamorous(View))
    in glamorous(View) (created by App)
    in App
Warning: Failed prop type: Invalid prop `style` of type `array` supplied to `Text`, expected `object`.
    in Text (created by glamorous(Text))
    in glamorous(Text) (created by App)
    in view (created by View)
    in View (created by glamorous(View))
    in glamorous(View) (created by App)
    in App
πŸ›   Built ./my-command.js in 2239ms
nitin42 commented 7 years ago

Yeah it gives error when rendering to sketch. I'll try to fix it later this week.

nitin42 commented 7 years ago

Well, this package depends on react-primitives for binding the aliases to the glamorous constructor. Seems like react-primitives relies on createClass method and the author has not updated that. As soon as he updates the codebase (with React 16), I'll fix this issue πŸ˜„