search

niwinz / django-jinja

Simple and nonobstructive jinja2 integration with Django.
http://niwinz.github.io/django-jinja/latest/
BSD 3-Clause "New" or "Revised" License
363 stars 102 forks source link

Adding ppc64le architecture support on travis-ci #271

Closed kishorkunal-raj closed 3 years ago

kishorkunal-raj commented 4 years ago

Hi, I had added ppc64le architecture support on travis-ci and looks like its been successfully added. Jobs depending on python3.9 is switched to python3.9-dev as python3.9 is still not supported on travis ci. I believe it is ready for the final review and merge.

Please have a look.

Thanks!! Kishor Kunal Raj

kishorkunal-raj commented 4 years ago

Reason behind changes: This package is included in the ppc64le versions of RHEL and Ubuntu - this allows the top of tree to be tested continuously as it is for Intel, making it easier to catch any possible regressions on ppc64le before the distros begin their clones and builds. This reduces the work in integrating this package into future versions of RHEL/Ubuntu.

Please review the changes and whether the changes are feasible or not to incorporate.

kishorkunal-raj commented 4 years ago

Jobs were failing earlier itself for python 3.9 before I added the changes. As python 3.9-dev is only available on travis-CI and not python 3.9 so far for amd64 as well as for ppc64le, hence the jobs were failing for 3.9. Also the build job you provided results to all passed jobs and no issues with it.

If you find the changes relevant, please allow it to merge

wizpig64 commented 4 years ago

Yes, I wasn't complaining, you fixed 3.9 which i broke :)

This PR looks mergeable to me.

kishorkunal-raj commented 4 years ago

Yes, I wasn't complaining, you fixed 3.9 which i broke :)

This PR looks mergeable to me.

Sorry, I miss interpreted. Thanks for accepting the changes!

kishorkunal-raj commented 3 years ago

Hi @wizpig64, Just because of curiosity, when will be the changes can be merged? Hope I didn't bother you by asking such question