for each configured system recurse into `.#checks.<system>` instead of recursing into `.#checks`

nix-community / buildbot-nix

A nixos module to make buildbot a proper Nix-CI [maintainer=@Mic92,@MagicRB]

MIT License

120 stars 24 forks source link

for each configured system recurse into `.#checks.<system>` instead of recursing into `.#checks` #302

Open steveej opened 2 months ago

steveej commented 2 months ago

https://github.com/nix-community/buildbot-nix/blob/3ff2595ac30873501c2331008ef24d2ab6992f58/buildbot_nix/__init__.py#L959

the issue with the current implementation is that it's leads to errors when combined with IFD and non-available builders for the non-native systems.

Mic92 commented 2 months ago

That would require some changes in nix-eval-jobs.

Mic92 commented 2 months ago

The disadvantage is though that you potentially hide eval errors for other platforms when doing that.

MagicRB commented 2 months ago

We need it to be configurable per repo, so it falls under the "per reps settings" thing which ive mentioned in the past. Also we could just ignore any eval errorrs for other than local platforms.