search

nix-community / napalm

Support for building npm packages in Nix and lightweight npm registry [maintainer=?]
MIT License
104 stars 17 forks source link

template: Fix output source, name #43

Closed cyntheticfox closed 1 year ago

cyntheticfox commented 1 year ago

The template flake provided looks to have had the hello-world-deps folder and files removed, but the flake reference to hello-world was removed instead of it. This text-replacement fixes such.

jtojnar commented 1 year ago

Yeah I am not even sure what https://github.com/nix-community/napalm/commit/b21ef95e0bc0eb9dd6fad7f869c33ffc18970a1c was supposed to achieve, it does not look like it was tested. Do you know if the template works now? We probably should add a CI to smoke test it.

cyntheticfox commented 1 year ago

Yeah, it looked to work, but better to add some kind of regression test to ensure it continues to work. I thought about that but then started to wonder about rearranging some of the rest of the code, which would probably best be a separate PR.

jtojnar commented 1 year ago

Sounds reasonable, thanks.