search

njcuk9999 / apero-drs

A PipelinE to Reduce Observations - The DRS for SPIRou (CFHT)
MIT License
12 stars 1 forks source link

exposuremeter mask #490

Closed clairem789 closed 6 years ago

clairem789 commented 6 years ago

I noticed that the cal_exposure_meter.py options may have been a bit confused with the change of location of the _pp files (or other DRS evolution). What I need here is to apply the mask calculation in the "raw" data format, since it is really to feed the exposuremeter in realtime. It seems to be wanting only _pp files, is only searching in the tmp/night_name/, and when given a pp file and requesting "raw" output, it does a map of 0s. Also tried with option outputs='all' and it also produces a map of 0s. Any clue?

njcuk9999 commented 6 years ago

I will take a look at this. It should take in a _pp file as the loc/wavelength etc is done on the _pp files. You are correct in outputs='all' which should produce the "raw" image with the dimensions/rotation of the raw image I will investigate why you just get a map of zeros (it should be zero or NaN filled around the edges but not zero everywhere)

njcuk9999 commented 6 years ago

Yep I can confirm this bug. The wavemap and tell_spec look fine though so it is just the mask_map that is zeros (not just in the raw case in the preprocess and drs versions too!). Will find and fix it asap.

njcuk9999 commented 6 years ago

Actually more than this the exposure map uses the tilt file and not the shape map so I will need to re-work cal_exposure_meter to use the shape map!

njcuk9999 commented 6 years ago

Okay the problem with the zero filling was a function changing the returns which hadn't been updated in cal_exposure_meter. Just need to figure out how to deal with the shape file instead of tilt now!