njthomson / SrvSurvey

A new to help Commanders in planet based opperations
GNU General Public License v3.0
38 stars 1 forks source link

Feedback on the new bio status window. #106

Closed Vic502 closed 4 months ago

Vic502 commented 6 months ago

Firstly, I like the new strikethrough effect on finished scans, it makes it a lot clearer on what is done.

The Rewards issue: When scanning a body with 1 bio signature, and 2 possible options, the Rewards indicated is not updated correctly.

E.g.: I entered a system and did an FSS. Elite Observatory BioInsights reported 2 possible signatures and indicated possible rewards of ~1-19 mil. At this stage (before reaching the body to do a DSS) SRV Survey had no data on the body's bio signatures and only indicated that it had 1 bio signature with a "?".

After the DSS, when the 1 bio signature was known, the Rewards section in the Bio Status window updated and indicated the "unknown" range of 1-19 mil (see screenshot below), the same as BioInsights had initially reported. At this stage (after the DSS), BioInsights had correctly updated with the rewards for the 1 known signature. Screenshot 2024-05-26 185719

After landing and finishing the scan and three samples of the signature, the Rewards section had updated to the FF bonus, but still included the "unknown" range for the 2 initial possibilities. (See screenshot). Screenshot 2024-05-26 190225

njthomson commented 6 months ago

When that overlay shows ? in a box - there's a mew button on the main window "bio summary" that will show the list of what species it thinks is on each body - similar to BioInsights.

The prediction logic needs much tuning, hence it over-predicts. I haven't decided how to represent that long list of potentials in the small space of an overlay. Hence it just has ? in a box for now.

njthomson commented 6 months ago

@Vic502 could you share a picture of the body info overlay? That might help reveal why BioInsights ruled out Stratum Tectonicas where I did not.

njthomson commented 6 months ago

And, when you saw those ? ... was there a credit range next to it?

Vic502 commented 6 months ago

And, when you saw those ? ... was there a credit range next to it?

No range.

Vic502 commented 6 months ago

@Vic502 could you share a picture of the body info overlay? That might help reveal why BioInsights ruled out Stratum Tectonicas where I did not.

Sure, let me jump back there quickly. Not 100% which window you want.

njthomson commented 6 months ago

@Vic502 could you share a picture of the body info overlay? That might help reveal why BioInsights ruled out Stratum Tectonicas where I did not.

Sure, let me jump back there quickly. Not 100% which window you want.

The new one with Atmosphere, pressure, materials, etc.

Targetting the body in the system map should bring it up.

njthomson commented 6 months ago

And, when you saw those ? ... was there a credit range next to it?

No range.

This part should be fixed in the most recent build. I need to do something similar at the time of the 3rd and final scan.

Vic502 commented 6 months ago

image Targeting the body doesn't show it. Flying closer. Correction: Selecting it doesn't show the info panel, targeting does.

Vic502 commented 6 months ago

image

njthomson commented 6 months ago

image Targeting the body doesn't show it. Flying closer.

There's selecting it, and also choosing it as the target destination. (When it gets a blue "pin" on top). Journal files only reveal when it is your destination.

Vic502 commented 6 months ago

Now I don't see anything wrong after returning to this body.

njthomson commented 6 months ago

Now I don't see anything wrong after returning to this body.

This is expected. The bug is that certain calculations do not occur on that 3rd and final scan. They do occur when re-entering a system.

Vic502 commented 6 months ago

Hope this helps. Let me know if I can test anything else specifically.

njthomson commented 6 months ago

Hope this helps. Let me know if I can test anything else specifically.

Noting where BioInsights rules out some species but SrvSurvey does not will be helpful. It will take a while to discern all the factors controlling the species.

njthomson commented 6 months ago

The main issue reported here should be fixed as of this build: https://github.com/njthomson/SrvSurvey/releases/tag/1.1.3.33

I saw see the reward not updating when expected for other reasons, will keep this bug open until those are fixed.

njthomson commented 4 months ago

These issues should be fixed now. Please let me know if you see them again.