njtierney / maxcovr

Tools in R to make it easier to solve the Maximal Coverage Location Problem
http://maxcovr.njtierney.com/
GNU General Public License v3.0
42 stars 11 forks source link

Look into a separate set of "roll your own" distance functions that integrate back with maxcovr #51

Open njtierney opened 6 years ago

njtierney commented 6 years ago

These could interface with google maps API or similar, which would mean that we could expand from using a circular distance to something more fine

mpadge commented 6 years ago

Awesome package Nick! I'll be telling lotsa peeps about this. In the meantime, I've submitted geodist to CRAN, if that helps here. (It's currently still in perjury, but should appear any day.) There's also dodgr if you want actual street distances. Let me know in that case, and I'll gladly help.

njtierney commented 6 years ago

Wow! Both of these packages look amazing, @mpadge !

At the moment I've got to iron out some kinks in the implementation before I do a (very) minor release.

I'm really keen to implement the dodgr package, it makes me think that there might be some iterative/stepwise/grammatical way to build up this kind of analysis here maybe?

Briefly, there might be cases where euclidean distance makes sense, say in a field somewhere, but then there might be others that dodgr distance would be best - say in an urban environment. I'd rather avoid an extra argument in the function, over an additional function that you pipe to this.