search

nkanaev / yarr

yet another rss reader
MIT License
3.02k stars 225 forks source link

Set auth without authfile #108

Closed pierreprinetti closed 2 years ago

pierreprinetti commented 2 years ago

With this patch, it is possible to pass username and password directly on the command line with:

yarr --auth 'username:password'

The corresponding environment variable comes handy with containers:

YARR_AUTH='username:password' yarr
nkanaev commented 2 years ago

Sorry, no. I'm strongly against exposing passwords via cli arguments

pierreprinetti commented 2 years ago

I am not interested in the cli argument actually; what I want is setting it via environment variable. Would that be OK for you?

nkanaev commented 2 years ago

I think auth-file is sufficient enough.

pierreprinetti commented 2 years ago

I think auth-file is sufficient enough.

Not for my use-case. I use fly.io and deploying a secret as a file forces me to expose it to Github (or put the secret in a volume), which is not optimal. Many infras assume that you pass secrets (and config) as env vars these days.

nkanaev commented 2 years ago

well, that sounds reasonable. ok, accepted. thanks!

arsfeld commented 2 years ago

Thanks for this, I'm also using fly.io to run Yarr and I had similar changes in a private fork.