nlewo / comin

GitOps For NixOS Machines
MIT License
241 stars 11 forks source link

nix/module.nix: Start comin after the network comes up #35

Open jpds opened 2 months ago

nlewo commented 2 months ago

If you add a local remote, comin could fetch new commit without having to rely on the network. Moreover, since comin polls periodically, i don't think it's an issue if it starts before the network: comin could fail on first iterations but then succeeds once the network it up.

So, i'm not in favor of adding such dependency.

What kind of issue did you encounter exactly?

jpds commented 2 months ago

It started up very early in my boot sequence (way before networkd and unbound) - and thus failed a bunch of times on DNS requests.

Even with a local remote, users will probably still need network connectivity to pull down the sources/cache.

I might just override this locally on all my boxes.