LWIP_PLATFORM_ASSERT defined at lwip/include/arch.h would use __FILE__ macro to print assert messages with file paths. But those paths would be absolute paths carrying informations about the build host.
On one hand, this might expose sensitive data about the building host, considering most would build the package under the home, especially when one is redistributing nsproxy, like onto Github releases or into a distro library.
On the other hand, this adds unneeded information and lowers the signal-to-noise ratio when one wants to trace the issue, especially when the source is built in a folder with a very long path.
grep -a 'lwip/ipv4/icmp.c' ~/Downloads/nsproxy_x86_64-linux-musl
Although only lwip sources are affected, only overload the assertion call in our header locally, to avoid impact to lwip sources and increased burnden to merge upstream changes.
nlzy
commented
2 months ago
LWIP_PLATFORM_ASSERTdefined at lwip/include/arch.h would use__FILE__macro to print assert messages with file paths. But those paths would be absolute paths carrying informations about the build host.On one hand, this might expose sensitive data about the building host, considering most would build the package under the home, especially when one is redistributing nsproxy, like onto Github releases or into a distro library.
On the other hand, this adds unneeded information and lowers the signal-to-noise ratio when one wants to trace the issue, especially when the source is built in a folder with a very long path.
An example of the exposed path could be obtained by simply downloading the latest Github release from https://github.com/nlzy/nsproxy/releases/download/v0.2.0/nsproxy_x86_64-linux-musl and running a simple grep command like this:
Although only lwip sources are affected, only overload the assertion call in our header locally, to avoid impact to lwip sources and increased burnden to merge upstream changes.