search

nmaguirre / eiffel-subtitle-converter

A Subtitle Converter developed in Eiffel using Design by Contract
MIT License
3 stars 2 forks source link

Missing implementation for routine SUBRIP_SUBTITLE.make_from_file #154

Open lukax77 opened 9 years ago

lukax77 commented 9 years ago

There should be a routine that takes as a parameter a file name and initialize the items list.

lukax77 commented 9 years ago

Resolved in rev. a901486

lukax77 commented 9 years ago

The routine had a bug that was solved in rev. bf28da3

saiema commented 9 years ago

You should replace 0, 1 and 2 with constants with a name that describes what the constant means.