nmfs-fish-tools / ghactions4r

Reusable github actions workflows for R packages
https://nmfs-fish-tools.github.io/ghactions4r/
12 stars 1 forks source link

feat: add additional args to yaml files #147

Closed Bai-Li-NOAA closed 3 days ago

Bai-Li-NOAA commented 1 week ago

This PR addresses issue #144

codecov-commenter commented 1 week ago

Codecov Report

Attention: Patch coverage is 99.36709% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.19%. Comparing base (d1ca9b5) to head (29b7717).

Files with missing lines Patch % Lines
R/use_r_workflows.R 99.20% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #147 +/- ## ========================================== + Coverage 94.01% 95.19% +1.18% ========================================== Files 3 4 +1 Lines 167 208 +41 ========================================== + Hits 157 198 +41 Misses 10 10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

Bai-Li-NOAA commented 1 week ago

@e-perl-NOAA, could you review this pull request? I will do a final cleanup after the review before merging the changes into the main branch.

Also, could you test the new feature using SS3 repos? For example:

e-perl-NOAA commented 1 week ago

Okay, I just added things in the r4ss repo which calls these workflows. It will take awhile for the tests to run and confirm that they work but I will let you know when they do. The r function to update the workflow does work (at least for the ubuntu additions) though of course I did have to change the branch once added from main to this one so that it will work when the github actions are running right now.

e-perl-NOAA commented 1 week ago

Ummm, so I keep getting this result which is weird because I'm pretty sure everything is right. Idk if this is just one of those situations (like many other things these days) where everything has decided to stop working properly or something else

Bai-Li-NOAA commented 1 week ago

@e-perl-NOAA, my bad! I gave the wrong branch name. The correct one is add-additional-args-to-yaml

uses: nmfs-fish-tools/ghactions4r/.github/workflows/r-cmd-check.yml@add-additional-args-to-yaml
    # uses: nmfs-fish-tools/ghactions4r/.github/workflows/r-cmd-check.yml@main
e-perl-NOAA commented 1 week ago

Okay it's working in r4ss (there is a problem with the macos run but that's a me problem with gh and APIs and github enterprise with single sign on, not a you problem)!

e-perl-NOAA commented 1 week ago

@Bai-Li-NOAA would it be too much trouble to add an input for env portion to the r-cmd-check for me to test out? I might not be able to get it to do what I want it to and thus it may not matter in the end. This could also be done in another branch not associated with this PR.

e-perl-NOAA commented 1 week ago

The env is to try to deal with API calls to the mac github actions runner.

Bai-Li-NOAA commented 1 week ago

@e-perl-NOAA Feel free to add an input of env to test in this branch or another branch, either works for me. I am not entirely sure about the desired input format for env portion, but let me know the details of the user case if you would like me to work on it.

e-perl-NOAA commented 1 week ago

Actually nevermind on the env, it already uses it. It looks like macs will just always cause strife in my life.

e-perl-NOAA commented 1 week ago

I assume that you will re-run with spell check before you merge.

e-perl-NOAA commented 1 week ago

I tried adding it and then realized that you already had the GITHUB_TOKEN in there which is what I wanted to try. Its nothing for you to worry about.

Bai-Li-NOAA commented 1 week ago

@e-perl-NOAA, okay, thanks for the update! I will do a final cleanup, including fixing the spell check GHA, before merging the PR.

Bai-Li-NOAA commented 3 days ago

@e-perl-NOAA I have merged the PR. You might need to update some GHA workflows in the SS3 repositories. Let me know if you have any questions!