nmfs-ost / asar

Partially automate a U.S. stock assessment report.
https://nmfs-ost.github.io/asar/
MIT License
15 stars 3 forks source link

Add SS3 integration tests for testing convert_output() #45

Closed Bai-Li-NOAA closed 2 months ago

Bai-Li-NOAA commented 2 months ago

This PR addresses issue #29

All tests have passed.

Bai-Li-NOAA commented 2 months ago

It won't affect the tests, but thanks for flagging it. There was a race condition where SS3 hadn’t finished saving reports before the code deleted irrelevant files. Since SS3 runs externally, the deletion sometimes happened too soon. I fixed it by moving the file deletion out of the parallel process.