search

nmfs-ost / asar

Partially automate a U.S. stock assessment report.
https://nmfs-ost.github.io/asar/
MIT License
15 stars 3 forks source link

Added code to add_theme.R to use the nmfs color palette in plots #53

Closed sbreitbart-NOAA closed 1 month ago

Bai-Li-NOAA commented 1 month ago

@Schiano-NOAA and @sbreitbart-NOAA The GHA workflows failed on push but not on the pull request. I suspect this might be due to the feature branch being behind the main branch. I ran a rebase test here, and all tests passed with no changes required to the actual code base. Would you like me to rebase the access_plot_theme branch and force push it?

I noticed that tests/testthat/test-add_theme.R is currently commented out. It would be helpful to update the tests and include some for the newly added code (e.g., usage of {nmfspalette}) before merging these changes into the main branch.

Schiano-NOAA commented 1 month ago

@Bai-Li-NOAA that would be great. Definitely move forward with the push after rebase and if you are able to update the add_theme test, it would be super helpful. Thanks!

Bai-Li-NOAA commented 1 month ago

@Schiano-NOAA, I will be co-working with @sbreitbart-NOAA on this later this afternnon. I think it's a great opportunity to introduce the testing framework and merge workflows.