search

nmfs-ost / asar

Partially automate a U.S. stock assessment report.
https://nmfs-ost.github.io/asar/
MIT License
15 stars 3 forks source link

Development branch for release v0.2 beta #55

Closed sbreitbart-NOAA closed 3 weeks ago

sbreitbart-NOAA commented 1 month ago

Attempt to inherit custom_sections parameter from asar::create_template()

Is this the correct way to inherit parameters from other functions within asar?

Schiano-NOAA commented 1 month ago

@sbreitbart-NOAA what did you push with the commit merge branch 'main' into dev?

Edit: resolved

Schiano-NOAA commented 1 month ago

@Bai-Li-NOAA there is an issue that I can't figure out with the test-add_chunk failing. I looked over it extensively and the test should pass but it is not. I don't think any changes were made to that function for the test to fail. Currently, it is commented out so I can make sure the remainder of the checks are passing and I'm not going crazy lol. Would you be able to check on this by the end of next week?

Bai-Li-NOAA commented 1 month ago

@Schiano-NOAA, that's frustrating! Yes, I’ll check it out by the end of next week.

Schiano-NOAA commented 1 month ago

@sbreitbart-NOAA @Steven-Saul-NOAA @Bai-Li-NOAA as long as all goes well, I am planning on merging this dev branch for beta 3 into the main by the end of next week. Will this give everyone time to complete any remaining tasks you may want for the next addition? (We will continue to use the dev branch post merge if you don't think you can finish up stuff by next week, but this will be a large update to the main).

Pleas reply to this comment whether this does or does not work for you and see if you can merge any current branches off the dev into dev by EOD next Friday. Thanks!!

sbreitbart-NOAA commented 1 month ago

@sbreitbart-NOAA @Steven-Saul-NOAA @Bai-Li-NOAA as long as all goes well, I am planning on merging this dev branch for beta 3 into the main by the end of next week. Will this give everyone time to complete any remaining tasks you may want for the next addition? (We will continue to use the dev branch post merge if you don't think you can finish up stuff by next week, but this will be a large update to the main).

Pleas reply to this comment whether this does or does not work for you and see if you can merge any current branches off the dev into dev by EOD next Friday. Thanks!!

@Schiano-NOAA Yes, I believe that's fine with me as long as we sort out the pkgdown-vignette PR :)