Open sbreitbart-NOAA opened 1 month ago
Hello reviewer, thanks for taking the time to review this PR!
nit:
(for nitpicking) before making the suggestion. For example, nit:
I prefer using a data.frame()
instead of a matrix
because...This PR is now ready to be merged, no changes needed
.I think this is failing (at least some) tests because the model output isn't being imported correctly into create_figures_doc.R
. It worked fine in my local testing in create_figures_doc.R
and create_template.R
when I could add the model results as a .csv with read.csv("my_model_results.csv")
, but I think there needs to be a step ensuring that the converted model output can be called within create_figures_doc.R
. Ideally, I think it'd be called within create_template.R
so that the objects can be called in both create_figures_doc.R
and create_tables_doc.R
.
What is the feature?
How have you implemented the solution?
create_figure_doc.R
. The values for those parameters are substituted for placeholders in the pre-written captions and alt text (sourced from captions_alttext.csv). The parameters are exported to the global R environment and referenced in the preamble in the skeleton .qmd file.Does the PR impact any other area of the project, maybe another repo?
create_template.R
andcreate_figure_doc.R
Plans for next steps
create_template.R
so that the objects can be called in bothcreate_figures_doc.R
andcreate_tables_doc.R
?