nmfs-ost / asar

Partially automate a U.S. stock assessment report.
https://nmfs-ost.github.io/asar/
MIT License
15 stars 3 forks source link

Build: Add automatically-extracted model parameters to alt text and captions #69

Open sbreitbart-NOAA opened 1 month ago

sbreitbart-NOAA commented 1 month ago

What is the feature?

How have you implemented the solution?

Does the PR impact any other area of the project, maybe another repo?

Plans for next steps

github-actions[bot] commented 1 month ago

Instructions for code reviewer

Hello reviewer, thanks for taking the time to review this PR!

Checklist

sbreitbart-NOAA commented 1 month ago

I think this is failing (at least some) tests because the model output isn't being imported correctly into create_figures_doc.R. It worked fine in my local testing in create_figures_doc.R and create_template.R when I could add the model results as a .csv with read.csv("my_model_results.csv"), but I think there needs to be a step ensuring that the converted model output can be called within create_figures_doc.R. Ideally, I think it'd be called within create_template.R so that the objects can be called in both create_figures_doc.R and create_tables_doc.R.