search

nmfs-ost / ss3-source-code

The source code for Stock Synthesis (SS3).
https://nmfs-ost.github.io/ss3-website/
Creative Commons Zero v1.0 Universal
36 stars 16 forks source link

[Bug]: Time_Series output of forecast recruitment in a seasonal model #605

Closed Rick-Methot-NOAA closed 2 weeks ago

Rick-Methot-NOAA commented 1 month ago

Describe the bug

A four season model with recruitment in each season found that the recruitment reported in the Time_Series table was incorrect for seasons > season 1. Investigation showed that the total recruitment for the year shown in the spawn_recr table is correct. Also, the numbers_at_age table is correctly showing the detailed numbers broken down by birthseason and season. The recruitment output for the Time_Series table needs to aggregate across birthseason and was doing it incorrectly for forecast years. The output for time_series years is correct.

Problem is resolved when a cluase checking on birthseason is removed in ss_benchfore.tpl

To Reproduce

see above

Expected behavior

recruitment output for each relevant season

Screenshots

No response

Which OS are you seeing the problem on?

No response

Which version of SS3 are you seeing the problem on?

3.30.22.01

Additional Context

No response

Rick-Methot-NOAA commented 1 month ago

demonstration of the fix is in attached excel file yft_numbers_2.zip