nmstate / kubernetes-nmstate

Declarative node network configuration driven through Kubernetes API.
GNU General Public License v2.0
172 stars 86 forks source link

Log setup steps when starting handler #1228

Closed mkowalski closed 4 months ago

mkowalski commented 5 months ago

We have observed that under specific conditions starting handler may hang indefinitely. In order to help debugging those issues, we are adding some logging to report steps happening when handler starts. Thanks to this, whenever a process hands, we will see which component is not responding.

Is this a BUG FIX or a FEATURE ?:

/kind enhancement

Release note:

NONE
mkowalski commented 5 months ago

This comes up as part of https://issues.redhat.com/browse/OCPBUGS-29266

qinqon commented 4 months ago

/retest

qinqon commented 4 months ago

/lgtm /approve

kubevirt-bot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/nmstate/kubernetes-nmstate/blob/main/OWNERS)~~ [qinqon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kubevirt-bot commented 4 months ago

@mkowalski: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-nmstate-e2e-handler-k8s-future 24231070601cfd3447cacaeaa9e568c878da8aad link false /test pull-kubernetes-nmstate-e2e-handler-k8s-future
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
qinqon commented 4 months ago

/retest