search

nnmware / devoops

DevOOPS Bootstrap 3 Admin theme
GNU General Public License v3.0
852 stars 416 forks source link

.show-sidebar click should return false #11

Closed joshkel closed 10 years ago

joshkel commented 10 years ago

While integrating the devoops theme into our own product, we ran into an issue where clicking the show / hide sidebar button navigated to #, which confused our logic for routing and background updating.

Changing the $('.show-sidebar').on('click') handler in devoops.js to return false fixes this.

devoopsme commented 10 years ago

Thanks for your note! We added preventDefault() for sidebar click event(return false - works too). Fixed in https://github.com/devoopsme/devoops/commit/a3eae29d405e3b0febfa726456ea5178607e9901