search

noaa-oar-arl / monetio

The Model and ObservatioN Evaluation Tool I/O package
https://monetio.readthedocs.io
MIT License
17 stars 20 forks source link

hotfix/_camx_mm #191

Closed blychs closed 3 weeks ago

blychs commented 3 weeks ago

Added the fixes mentioned in Issue #189 . Hopefully nothing new and unexpected shows up!

blychs commented 3 weeks ago

@zmoon I only wonder about the layer_height vs layer_thickness thing that we were discussing in #184. I am not sure about which conclusion we've reached?

zmoon commented 3 weeks ago

I think it's fine to call them what you want for now, and we'll come up with the standardized names and update readers later.

blychs commented 3 weeks ago

In that case, it is pretty much ready to merge. The advantage of having consistent names accross readers is for the melodies-monet utility. My utility right now reads layer_height_agl, but I can just add temporarily a check to check for different variable names and accommodate for different readers.

blychs commented 3 weeks ago

Zach, I am sorry, I made a mistake by not noticing that I had changed my working branch (to include both tempo and camx in the same), and a couple of bugs that were corrected later slipped here. Should I open a new pull request?

On Wed, Sep 11, 2024 at 12:17 PM Zachary Moon @.***> wrote:

Merged #191 https://github.com/noaa-oar-arl/monetio/pull/191 into develop.

— Reply to this email directly, view it on GitHub https://github.com/noaa-oar-arl/monetio/pull/191#event-14220829306, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJPVNVNAOWEMUENLQEGNSSDZWCCNNAVCNFSM6AAAAABNZKOTPGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGIZDAOBSHEZTANQ . You are receiving this because you were mentioned.Message ID: @.***>

-- Atmospheric Chemistry Observations & Modeling (ACOM) Lab NSF National Center for Atmospheric Research (NCAR) - UCAR P.O. Box 3000, Boulder, CO 80307-3000, USA Office Nº: FL0 - 2162 Email: @. @.>*