Closed zmoon closed 1 year ago
@mebruckner @rschwant does this look ok? I based the renames on the ones of @rschwant .
@zmoon It looks good to me. I can test it and update the raqms melodies-monet commit to reflect this change.
@mebruckner that would be great, thanks
Yes, @zmoon this looks good to me.
@mebruckner I'm going to merge this, if you find an issue we can address in another PR.
CI failures upon merge (though passing before) due to:
(tutorial/aqs_pams: line 27) broken https://aqs.epa.gov/aqsweb/airdata/download_files.html - HTTPSConnectionPool(host='aqs.epa.gov', port=443): Max retries exceeded with url: /aqsweb/airdata/download_files.html (Caused by SSLError(SSLError(1, '[SSL: UNSAFE_LEGACY_RENEGOTIATION_DISABLED] unsafe legacy renegotiation disabled (_ssl.c:1129)')))
FAILED tests/test_aqs.py::test_aqs - requests.exceptions.SSLError: HTTPSConnectionPool(host='aqs.epa.gov', port=443): Max retries exceeded with url: /aqsweb/airdata/daily_PM10SPEC_2019.zip (Caused by SSLError(SSLError(1, '[SSL: UNSAFE_LEGACY_RENEGOTIATION_DISABLED] unsafe legacy renegotiation disabled (_ssl.c:1131)')))
xref: https://github.com/NOAA-CSL/MELODIES-MONET/pull/99#discussion_r949606252