noahd1 / oink

Log parser to identify actions which significantly increase VM heap size
MIT License
1.18k stars 71 forks source link

Add support for an averaged output #20

Closed bjpirt closed 11 years ago

bjpirt commented 11 years ago

This pull request adds support for an aggregated display of the memory usage which is helpful for not just finding which action is responsible for the largest increases, but which action is responsible for the most total memory increase. It adds a section that looks like this:

  Aggregated Totals:
  Action                                  Max     Mean    Min     Total   Number of requests
  SportsController#show                   101560  19754   4       5590540 283
  CommentsController#create               8344    701     4       253324  361
  ColorSchemesController#show             10124   739     4       68756   93
  PublicPagesController#join              9004    1346    8       51172   38
  DashboardsController#show               13696   2047    8       45036   22
  SessionsController#create               9220    528     8       17448   33
  GroupsController#show                   10748   1314    8       15776   12
gabecoyne commented 11 years ago

I'd love to see this get added

bjpirt commented 11 years ago

@noahd1 Any chance you could either pull or close this? Shame to see a useful project stagnate.

noahd1 commented 11 years ago

Thanks for this commit, looks great. Sorry for the delay in merging it. I'll put out a new release.

bjpirt commented 11 years ago

Awesome! Thank you.