search

noaione / shosetsu-extensions

N4O Shosetsu Extension Collection
https://shosetsu.app/
GNU General Public License v3.0
10 stars 2 forks source link

[BUG] Reigokai - Isekai Lunatic #4

Closed nachfuellbar closed 7 months ago

nachfuellbar commented 7 months ago

Effected Extension Reigokai - Isekai Lunatic

Describe the bug In Shosetsu the novel translation https://isekailunatic.com/this-world-is-a-game/ is shown as "Share this:" which is a string grepped from just above the facebook and x buttons The page title in the html head of the page is salvagable on this title but no other mention seems to occur Maybe some fallback like "if i get Share This, use page title instead" would help

To Reproduce Steps to reproduce the behavior:

  1. Go to the extension
  2. Click on 'The World is a Game"
  3. After loading the chapters it's already displaying the wrong name

Expected behavior To show the real novel name

noaione commented 7 months ago

That part should be removed actually, I'll fix it later

Edit: I misunderstood the problem, will fix soon

noaione commented 7 months ago

Should be fixed by https://github.com/noaione/shosetsu-extensions/commit/8bc13e6ea70e584bfd04ab3b2591cf6084d61588

nachfuellbar commented 7 months ago

Looks good to me Now I see the right title :)