search

nobiot / org-remark

Highlight & annotate text, EWW, Info, and EPUB
https://nobiot.github.io/org-remark/
GNU General Public License v3.0
436 stars 22 forks source link

Improve error message when essential props are missing from the property drawer.... #47

Closed oatmealm closed 1 year ago

oatmealm commented 1 year ago

Not sure if this is related to the previous issue I've reported, but I've noticed that when the props ~:org-remark-beg:~ and ~ :org-remark-end:~ are missing, when the mode is activated you see this unhelpful error: "org-remark-highlights-load: Wrong type argument: stringp, nil"... now, I'm not sure why it was missing, but just in case it's possible to validate the existence of the essential props, it might be helpful...

nobiot commented 1 year ago

Deleted my confusing previous comments.

As I mention in https://github.com/nobiot/org-remark/issues/46#issuecomment-1365599482

I have rolled back the main to https://github.com/nobiot/org-remark/commit/618d60393961f83f0e18881d970f070063064f13. It should be more stable. All the latest changes are in PR https://github.com/nobiot/org-remark/pull/48.

You can manually remove :org-remark-note-body: from your notes. It should never been a property in notes files (now fixed in PR https://github.com/nobiot/org-remark/pull/48).

@oatmealm I really appreciate your sending these reports. Let me know if your notes are OK now. Let me know if you have more issues stemming from all these commits that went into the main prematurely.

nobiot commented 1 year ago

51 has gone in with a bunch of fixes to round off the previous update. I believe this issue reported here is a one-off event and does not recur any longer. Please reopen/recreate if the issue persists.