search

nobleo / rviz_satellite

Display internet satellite imagery in RViz
Apache License 2.0
570 stars 238 forks source link

ROS build farm integration #80

Closed Timple closed 3 years ago

Timple commented 4 years ago

I've noticed a lot of refactoring being done. Glad to see this code is maintained!

Would you also be interested in creating a release for melodic so we don't need to build from source?

Thanks for considering!

schra commented 4 years ago

Not totally sure what exactly you are referring to as a Melodic release.

But regarding not building from source: Integration into the ROS build farm is something that we might do in the future. What I can definitely do however, is to attach a .deb file to next releases.

Timple commented 4 years ago

Integration into the ROS build farm is exactly what I meant. It is like a 2 hour job the first time you do it. After that pushing updates is easy.

No need to attach .deb files, that would be a-typical from all other ROS packages and (thus) we wouldn't use that.

Thanks for considering!

Timple commented 4 years ago

Today a call for testing was done on discourse for Noetic, so when this issue is picked up, please also release for Noetic :slightly_smiling_face:

Timple commented 3 years ago

Would you mind if I release your package to the buildfarm?

Timple commented 3 years ago

Pending: https://github.com/ros/rosdistro/pull/28039