search

node-dmx / dmx

DMX controller library for node.js
MIT License
298 stars 94 forks source link

Port dmx to TypeScript #109

Closed Granjow closed 3 years ago

Granjow commented 3 years ago

This PR refers to #99.

Please comment on the first draft. Warning: It does not run yet as the port is WIP.

hrueger commented 3 years ago

Hi @Granjow , Can I help with this PR?

I'd really like to see this getting merged, as I want to add DMX receiving functionality. This will be way easier using TypeScript.

Granjow commented 3 years ago

Hi @hrueger , yes, that would be kind. Most important would be a short review of the current TypeScript interface (to see if it makes sense and if it would work for you too) before we start porting the code. If it looks okay from your side, I would then complete the Enttec driver and I'd be very happy about any help in the other drivers and in general!

hrueger commented 3 years ago

@Granjow I've sent an email about collaborating to the mail address on your website.

Cyberuben commented 3 years ago

Is there still any activity on this? I'd love to see this working

Granjow commented 3 years ago

From our side the port should be complete! Some drivers are even tested.

Also, Enttec USB Open works now.

Open for review/merge!

hrueger commented 3 years ago

@wiedi Any update on this? I'm using it currently and it works great.

wiedi commented 3 years ago

Hi, when this was proposed I thought this was just about adding some type annotations, while the rest would stay compatible. Now this seems to be a 10k+ line rewrite into a language I don't understand.

I am not able to review this or maintain it.

I understand that a lot of energy went into this and that it seems to be useful. Given that this breaks the API maybe it would make sense to move this into a separate repository? I'd be happy to create a "dmx-ts" or similar thing under the node-dmx organisation and give you admin rights. Would that make sense?

hrueger commented 3 years ago

I can totally understand you. I'd be happy with dmx-ts!

wiedi commented 3 years ago

Alrighty. I've sent an invite to you @hrueger and @Granjow that should grant admin access to it. With that you should be able to push and then switch the repo public. Let me know if you need anything more.

hrueger commented 3 years ago

Thanks a lot. I'll push tomorrow.

hrueger commented 3 years ago

@wiedi I'm done. Sorry for the commit history, but I've had a few problems with the spec test which would work on windows but not on linux. Hope it doesn't matter 👍

@Granjow I added / changed a couple of things:

wiedi commented 3 years ago

Fantastic!

Granjow commented 3 years ago

@wiedi Thanks, could you send the invitation again? Was offline the last few days.

@hrueger Sounds very good, thank you!

Once I have access I can restore the commit history, I'm a bit used to doing such stuff ;)

wiedi commented 3 years ago

Sure, done