EnttecUSBDMXPRO Driver Buffer API Fix (No Polyfill)

node-dmx / dmx

DMX controller library for node.js

MIT License

297 stars 96 forks source link

EnttecUSBDMXPRO Driver Buffer API Fix (No Polyfill) #61

Closed pboyd04 closed 5 years ago

pboyd04 commented 6 years ago

This is a non-polyfill version of #54. @wiedi , Do you like this better?

Fensterbank commented 5 years ago

@wiedi Should we merge this and the other Buffer API pull requests from @pboyd04?

Even If we aren't able to test all, I don't think there will be any issues. On the other hand the PRs are starting to rot and updating the deprecated things make sense.

Is #54 obsolete with this pull request?

wiedi commented 5 years ago

Yes, I think the approach taken in this PR is much better, thanks!

Still would be good to have the complete code base converted. I also think the API change is mechanical enough that testing every driver won't be needed.

Fensterbank commented 5 years ago

Thanks. Merged! 🍪