search

node-dmx / dmx

DMX controller library for node.js
MIT License
297 stars 96 forks source link

easing not working in animations #67

Closed seriousManual closed 5 years ago

seriousManual commented 5 years ago

Hello, easing is not working in animations because the options field is ignored when setting up the animation.

Fensterbank commented 5 years ago

@seriousManual Nice catch, thanks!

We are getting the option and setting a default value for it https://github.com/wiedi/node-dmx/blob/5b28517c718fb2d28f1495d55be61bcbee08705f/anim.js#L14

but finally a hard coded string linear is used. https://github.com/wiedi/node-dmx/blob/5b28517c718fb2d28f1495d55be61bcbee08705f/anim.js#L52

Quite easy to fix. First come first serve.

seriousManual commented 5 years ago

I took the liberty and created a PR :)