search

node-dmx / dmx

DMX controller library for node.js
MIT License
297 stars 96 forks source link

FIX(animation): consider easing options #68

Closed seriousManual closed 5 years ago

seriousManual commented 5 years ago

Up to now a default easing method 'linear' was used even if the easing option has been set.

This commit makes sure that the assigned easing option is considered when animating.

fixes #67

Fensterbank commented 5 years ago

@seriousManual Just mentioning you made this commit with ma.nst@m**dpk.de and not with the mail address of your Github profile, therefore your commits (also in the other PR) cannot be referenced to your Github. (you see it by the missing profile pictures of the commit)

Maybe you want to change the mail address in the git config and make a git commit --amend and git push --force before I merge? ;)

seriousManual commented 5 years ago

Hi, thanks a lot for the heads up! I was doing this change on my work laptop and forgot to change the author config!

It's amended and pushed!

Fensterbank commented 5 years ago

Thanks! Merged. 🍪