Upgrade serialport dependency for Node v12

node-dmx / dmx

DMX controller library for node.js

MIT License

297 stars 96 forks source link

Closed foxxyz closed 4 years ago

foxxyz commented 5 years ago

As documented here (https://github.com/serialport/node-serialport/issues/1905), the currently pinned version of serialport (6.0.4) no longer compiles using Node v12 and makes it so dmx cannot be installed.

Versions 7 and 8 do compile on Node v12, so a dependency upgrade would probably fix it.

OS: MacOS Node version: 12.8.0 CPU: 3.1Ghz Intel i7

foxxyz commented 4 years ago

@Fensterbank any chance of accepting #87?

Fensterbank commented 4 years ago

Yup. Thanks for the mention. :)

Fensterbank commented 4 years ago

PR #87 was merged and the issue is resolved.