search

node-dmx / dmx

DMX controller library for node.js
MIT License
297 stars 96 forks source link

upgrade serial port to 7.x #87

Closed sdeboeck closed 4 years ago

sdeboeck commented 4 years ago

Still have to be tested with a usb driver. Compiles on node v10 and v12

resolves issue #87

Fensterbank commented 4 years ago

@sdeboeck Thanks for your PR. I noticed you removed package-lock.json from the repository. This file is ment to be committed to the repository. If you re-add the previously existing package-lock.json and run an npm install, the file should be updated containing the new serial port version.

I will make a short test with my usb driver ASAP.

sdeboeck commented 4 years ago

@Fensterbank the package-lock.json is still in the repository. The diff isn't showing because to much changes.

I also will try to test it with a usb driver in the beginning of next week.

foxxyz commented 4 years ago

FYI: I ran a basic test with an Enttec USB DMX Pro using @sdeboeck's fork and did not notice any change in functionality.

Fensterbank commented 4 years ago

Thanks. Tested it too and seems good.

H-s-O commented 4 years ago

Has this been published yet? npm i dmx still tries to install serialport@6.2.2 which crashes on build with Node 12.

bluemaex commented 4 years ago

@H-s-O Thanks for the reminder. Just published a new version.

H-s-O commented 4 years ago

@bluemaex Thanks!