search

node-dmx / dmx

DMX controller library for node.js
MIT License
297 stars 96 forks source link

added socketio driver #89

Closed hrueger closed 4 years ago

hrueger commented 4 years ago

This driver uses socketio to send the universe data as an array over to other programms. The debug mode prints connect and disconnect messages.

hrueger commented 4 years ago

Is there anything else which has to be done before this PR can be merged?

Fensterbank commented 4 years ago

While I did not make tests, it looks fine for me. Thanks for your work. @wiedi or @bluemaex, any thoughts on this? I think we can merge it, since it does not affect any existing things and obviously works for @hrueger.

wiedi commented 4 years ago

Maybe it should be called "socketio" instead of just "socket" because that's very generic. Other than that I think it's fine

hrueger commented 4 years ago

In the commit message there's a spelling misstake, but in the code it is written correctly

wiedi commented 4 years ago

Thanks! I've squashed it so the commit message is fine.

hrueger commented 4 years ago

Oh, I somehow forgot to add the driver to the readme's driver list, should I create a new pull request for this? Or do you think that this is not necessary since it is not a 'real' hardware driver?

wiedi commented 4 years ago

Sure, correct documentation would be good :)