search

node-dmx / dmx

DMX controller library for node.js
MIT License
297 stars 96 forks source link

Add types for typescript support #99

Closed nofalx closed 2 years ago

nofalx commented 4 years ago

Hi im using your library for a project and it seems to lack types for typescript. I believe adding support for it would really make this library more awesome. I can help you with this and add types. Would you be willing to add support if I open a PR? Thank you

bluemaex commented 4 years ago

@nofalx Yes, please feel free to add a PR for types, I would happily review it!

Granjow commented 3 years ago

@bluemaex In case I get this working for the Starville LED Pixel Rail – would you accept a MR which migrates this project to TypeScript?

bluemaex commented 3 years ago

@Granjow I would be totally fine with that! But please in that case please also add a build target and instructions :)

Bordman-ger commented 3 years ago

@Granjow Maybe I can help you? I am getting the same problem (trying to get an IOBroker adapter working using TypeScript) maybe we can work on this together? or at least I can help testing ....

Granjow commented 3 years ago

Sorry for the late response. Ended up using ArtNet for the LED Rail (https://www.npmjs.com/package/artnet-base). We have another DMX device though and I will probably need the library there. If I do, I will do the TypeScript port (should be fairly straightforward), testing would definitely be very helpful then!

wiedi commented 2 years ago

I think https://github.com/node-dmx/dmx-ts solves this.