node-forward / mentors

Building up the node community through mentoring
108 stars 49 forks source link

Fixed wrong URL for issue #49 #56

Closed ifraixedes closed 9 years ago

ifraixedes commented 9 years ago

I've fixed wrong URL for issue #49 and replaced by anchor than a raw URL

jasonrhodes commented 9 years ago

Hey thanks! Did you test this change? It looks like I forgot the ".com" originally but it doesn't look like that's been added so this change may still not work.

Alternately, you could use the //#49 syntax which will auto-link.

Wanna update so I can merge? You can amend and force push your commit.

ifraixedes commented 9 years ago

Yeah, I thought that I tested, but obviously, I didn't. I'm trying to use the autolink, but I cannot find what I have to type, I tried with (without tildes) //#49,#49 and [#49](//#49) but they didn't work.

I don't know that it is the short version, can you tell me how?

Sorry for the silly issue. Thanks

jasonrhodes commented 9 years ago

Haha my comment got html encoded. The auto link syntax is {org or user}/{repo}/#49

ifraixedes commented 9 years ago

I tried with that but I could make it to work; I think that it work for commit messages, issues' comments, etc, however it does not apply for Markdown docs into the repo, is it?

By the way, I updated with the absolute URL

jasonrhodes commented 9 years ago

Ah that might be right, thanks!