search

node-red / node-red-node-swagger

A set of tools for generating Swagger api documentation based on the HTTP nodes deployed in a flow
Apache License 2.0
62 stars 46 forks source link

Improved search for response nodes #64

Closed guy-datacom closed 4 years ago

guy-datacom commented 5 years ago

checkWiresForHttpResponse() does not currently look beyond the first wire when checking for response nodes. My flows have many multi-output function nodes that meant this module didn't find the response nodes. This change fixes that, and does not seem to have any other consequences.

jsf-clabot commented 5 years ago

CLA assistant check
All committers have signed the CLA.

dceejay commented 5 years ago

You seem to have added a load of unnecessary white space changes that makes it very hard to see what the actual changes are. Please revert them and update the PR. Also please don't change the source url in package.json.

Thanks

guy-datacom commented 5 years ago

Hi, thanks for the module. The more I’ve used it the more I’ve thought about investing some effort into it beyond that small hack. Have you looked at what might be involved in implementing openapi 3.0? Is that something anyone is currently working on?

Regards

Guy

On 5 Mar 2019, at 9:42 pm, Dave Conway-Jones notifications@github.com<mailto:notifications@github.com> wrote:

You seem to have added a load of unnecessary white space changes that makes it very hard to see what the actual changes are. Please revert them and update the PR. Also please don't change the source url in package.json.

Thanks

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/node-red/node-red-node-swagger/pull/64#issuecomment-469632071, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AtV5z7VoLHy82JJ1Jh7jD6TapZ01C-suks5vTkn3gaJpZM4bYDu6.

JonSilver commented 4 years ago

Have you looked at what might be involved in implementing openapi 3.0? Is that something anyone is currently working on?

I'd be happy to collaborate on such a quest, @guy-datacom. There are lots of discussion points regarding a move to OpenAPI 3.0. Lots of breaking changes to code, and there's now a React-based branch replacing the backbone.js one. It looks like there are even competitor libraries that produce OpenAPI compatible definitions.

For now I've done some work to get rid of problematic contributed commits, restore the core functionality without the introduced bugs, and modernise the code.

knolleary commented 4 years ago

Resolved by #67