search

nodefluent / node-sinek

:tophat: Most advanced high level Node.js Kafka client
MIT License
290 stars 52 forks source link

add headers support #151

Closed alkiskal closed 4 years ago

alkiskal commented 4 years ago

Adds headers support for NProducer/NConsumerr

https://github.com/Blizzard/node-rdkafka/blob/d07bc6b0ee25c470c4f2ff8bbbe721946e96b49a/examples/producer.md

High level producer of node-rdkafka supports headers

yrsh commented 4 years ago

Any updates on this issue? When it will be merged?

krystianity commented 4 years ago

@alkiskal thanks for this PR, why not just pass the headers as object? any specific reason why you pass it as array?

alkiskal commented 4 years ago

@krystianity yes, this was my first approach but when I tried it manually it didn't work. It needs to be an array. That's why I added the link of rdkafka in my description. The example also uses an array for the headers.